Skip to content

Commit

Permalink
ci: install test deps from setup.py
Browse files Browse the repository at this point in the history
Includes special handling for the circleci/python:3.4 image, which
doesn't setup PATH properly. This isn't worth fixing right now, as it is
likely that we'll deprecate Python 3.4 support very soon.
  • Loading branch information
rohitpaulk committed Apr 17, 2020
1 parent 9f54e71 commit 84ea6ad
Showing 1 changed file with 15 additions and 3 deletions.
18 changes: 15 additions & 3 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,7 @@ jobs:
- image: circleci/python:2.7
steps:
- checkout
- run: pip install --user .
- run: sudo pip install coverage pylint==1.9.3 flake8 mock==3.0.5
- run: pip install --user .[test]
- run:
name: Linting with Flake8
command: |
Expand All @@ -59,9 +58,22 @@ jobs:
- run: make e2e_test

test_34:
<<: *test
docker:
- image: circleci/python:3.4
steps:
- checkout
- run: pip install --user .[test]

# The circleci/python:3.4 image doesn't set PATH correctly, so we need to
# install these by hand with sudo
- run: sudo pip install coverage pylint==1.9.3 flake8 mock==3.0.5

- run:
name: Linting with Flake8
command: |
git diff origin/master..HEAD analytics | flake8 --diff --max-complexity=10 analytics
- run: make test
- run: make e2e_test

test_35:
<<: *test
Expand Down

0 comments on commit 84ea6ad

Please sign in to comment.