Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: string formatting #23

Merged
merged 1 commit into from
Jan 8, 2024
Merged

fix: string formatting #23

merged 1 commit into from
Jan 8, 2024

Conversation

esadek
Copy link
Member

@esadek esadek commented Oct 25, 2023

Description of the change

Fix string formatting for message size limit runtime error.

Before:

RuntimeError: ('Message exceeds %skb limit. (%s)', '32', "{'integrations': ...

After:

RuntimeError: Message exceeds 32kb limit. ({'integrations': ...

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@sonarcloud
Copy link

sonarcloud bot commented Oct 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bardisg bardisg self-requested a review November 23, 2023 11:21
@bardisg
Copy link

bardisg commented Nov 23, 2023

Resolves SDK-804

@itsdebs itsdebs merged commit a8d617c into master Jan 8, 2024
10 checks passed
@itsdebs itsdebs deleted the fix-string-formatting branch January 8, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants