Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate database encryption as a plugin #261

Conversation

1abhishekpandey
Copy link
Contributor

@1abhishekpandey 1abhishekpandey commented Oct 9, 2023

Description of the change

  • Created a DBEncryption plugin for React Native.
  • In Android, it is no longer required to explicitly mention the SQLcipher dependency as that comes bundled with the plugin.
  • In iOS, the SQLCipher redefinition issue has been solved.
  • React Native iOS SDK minimum version is updated to v1.23.0. In this version, we have introduced a check to detect if the SQLCipher is available at the runtime or not. This is to address the static linkage issue.
  • BREAKING CHANGE: The DBEncryption class has been relocated from the React Native core SDK to the DBEncryption plugin. (It'll require updating the import if someone is already utilising this class.)

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@sonarcloud
Copy link

sonarcloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@1abhishekpandey 1abhishekpandey merged commit d798eee into develop Oct 16, 2023
18 checks passed
@1abhishekpandey 1abhishekpandey deleted the feat/sdk-600-reimplement-dbencryption-feature-in-react-native-ios branch November 1, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants