-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve getRudderContext api return type #273
fix: improve getRudderContext api return type #273
Conversation
Return type is updated from void to IRudderContext or null
3109f2b
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@1abhishekpandey Was this merged? If so could you remove it? We would prefer not to have anything logged when fetching context.
UPDATE: this comment was supposed to reference the new console.log statement but the GitHub mobile UI threw me off haha
Hey @elliotdickison, |
Ah I missed that, thanks! |
Description of the change
IRudderContext
interface in the React Native SDK, which basically defines the context fields. Now this interface is also exported.getRudderContext
API return type fromvoid
toIRudderContext | null
.Type of change
Related issues
Checklists
Development
Code review