Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use the sqlcipher-android library in db encryption android plugin #363

Conversation

1abhishekpandey
Copy link
Contributor

@1abhishekpandey 1abhishekpandey commented Aug 16, 2024

Description of the change

  • Provide support for the latest DBEncryption plugin by replacing net.zetetic:android-database-sqlcipher with net.zetetic:sqlcipher-android. Corresponding changes have already been done on the native Android side since v1.23.0.
  • Bumped the native Android SDK to the latest version in the DBEncryption Android module.
  • Set the Cocopod version to 1.15.2 in build-ios-checks.yml and check-compatibility-of-native-sdks.yml.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

…roid dependency in db encryption plugin

And remove the deprecated net.zetetic:android-database-sqlcipher dependency
@1abhishekpandey 1abhishekpandey self-assigned this Aug 16, 2024
@1abhishekpandey 1abhishekpandey requested a review from a team as a code owner August 16, 2024 13:38
@1abhishekpandey 1abhishekpandey marked this pull request as draft August 16, 2024 13:58
… setup cocoapod in build-ios-checks.yml"

This reverts commit 5e9efa9.
… setup cocoapod in check-compatibility-of-native-sdks.yml"

This reverts commit 4c7a33d.
….2 in build-ios-checks.yml"

This reverts commit d7211b2.
….2 in check-compatibility-of-native-sdks.yml"

This reverts commit 0080d96.
Copy link

sonarcloud bot commented Aug 16, 2024

@1abhishekpandey 1abhishekpandey marked this pull request as ready for review August 16, 2024 14:35
@1abhishekpandey 1abhishekpandey merged commit 31c049c into develop Aug 19, 2024
14 checks passed
@1abhishekpandey 1abhishekpandey deleted the feature/sdk-1649-replace-the-cipher-dependency-in-the-react-native-db branch August 19, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants