Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for rudder facebook integration #373

Merged
merged 12 commits into from
Sep 23, 2024
Merged

feat: add support for rudder facebook integration #373

merged 12 commits into from
Sep 23, 2024

Conversation

1abhishekpandey
Copy link
Contributor

@1abhishekpandey 1abhishekpandey commented Sep 18, 2024 •
edited
Loading

Description of the change

  • In this PR, we've added a new RN plugin for Facebook App Events integrations.
  • I added the setup for Facebook App Events SDK initialisation on React Native Android and iOS sample apps.
  • Addressed a high vulnerability issue.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@1abhishekpandey 1abhishekpandey self-assigned this Sep 18, 2024
@1abhishekpandey 1abhishekpandey marked this pull request as ready for review September 19, 2024 16:11
@1abhishekpandey 1abhishekpandey requested a review from a team as a code owner September 19, 2024 16:11
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

ChryssaAliferi
ChryssaAliferi approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@ChryssaAliferi ChryssaAliferi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@1abhishekpandey 1abhishekpandey merged commit 8cac746 into develop Sep 23, 2024
13 checks passed
@1abhishekpandey 1abhishekpandey deleted the feature/sdk-2289-implement-changes-on-rn-sdk branch September 23, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikumarrs saikumarrs saikumarrs approved these changes

@SKannaniOS SKannaniOS SKannaniOS approved these changes

@ChryssaAliferi ChryssaAliferi ChryssaAliferi approved these changes

Assignees

@1abhishekpandey 1abhishekpandey

Labels
Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@1abhishekpandey @ChryssaAliferi @SKannaniOS @saikumarrs