Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: alias api #377

Merged
merged 3 commits into from
Sep 27, 2024
Merged

fix: alias api #377

merged 3 commits into from
Sep 27, 2024

Conversation

saikumarrs
Copy link
Member

Description of the change

I've fixed the declarations and implementation of the alias API.

  • Marked alias(previousId, newId) as deprecated.
  • Added the correct function declaration alias(newId, [options]) to the API.
  • The API was also fixed to return the promise from the bridge.
    • We have to do this for all the other APIs as well later.

Misc:

  • Updated the sample app with all the correct usages of the alias API.
  • Also, added the missing package-lock.json file.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@saikumarrs saikumarrs self-assigned this Sep 27, 2024
@saikumarrs saikumarrs requested a review from a team as a code owner September 27, 2024 11:21
Copy link
Contributor

@1abhishekpandey 1abhishekpandey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

libs/sdk/src/RudderClient.ts Outdated Show resolved Hide resolved
apps/example/src/app/RudderEvents.tsx Show resolved Hide resolved
Copy link

sonarcloud bot commented Sep 27, 2024

@saikumarrs saikumarrs changed the title fix: alias api declaration issue fix: alias api Sep 27, 2024
@saikumarrs saikumarrs merged commit b9168cf into develop Sep 27, 2024
15 checks passed
@1abhishekpandey 1abhishekpandey deleted the fix.alias-api-sdk-2420 branch September 27, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants