-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: sync release v1.38.4 to main branch #5333
Merged
mihir20
merged 11 commits into
master
from
sync-release-884f7b9d77a259eafd8ac2a5423e1d888ff3e7a2
Dec 20, 2024
Merged
chore: sync release v1.38.4 to main branch #5333
mihir20
merged 11 commits into
master
from
sync-release-884f7b9d77a259eafd8ac2a5423e1d888ff3e7a2
Dec 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: bing ads audience (#5299) * chore: handle 500kb limit, refactor to service impl (#5302) * chore: handle 500kb limit, refactor to service impl * chore: fix mock * chore: fix mock newline * chore: fix apiservice newline * chore: move error --------- Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5333 +/- ##
==========================================
+ Coverage 74.77% 74.81% +0.04%
==========================================
Files 437 437
Lines 61243 61239 -4
==========================================
+ Hits 45793 45816 +23
+ Misses 12913 12884 -29
- Partials 2537 2539 +2 ☔ View full report in Codecov by Sentry. |
…9d77a259eafd8ac2a5423e1d888ff3e7a2 # Conflicts: # CHANGELOG.md # mocks/router/klaviyobulkupload/klaviyobulkupload_mock.go # router/batchrouter/asyncdestinationmanager/klaviyobulkupload/apiService.go # router/batchrouter/asyncdestinationmanager/klaviyobulkupload/klaviyobulkupload.go # router/batchrouter/asyncdestinationmanager/klaviyobulkupload/klaviyobulkupload_test.go
cisse21
approved these changes
Dec 20, 2024
mihir20
approved these changes
Dec 20, 2024
mihir20
deleted the
sync-release-884f7b9d77a259eafd8ac2a5423e1d888ff3e7a2
branch
December 20, 2024 12:07
mihir20
pushed a commit
that referenced
this pull request
Dec 20, 2024
* fix: bq partitioning for additional columns (#5293) * chore: release 1.38.1 (#5295) * fix: klaviyo bulk upload and BingAds OC (#5305) * fix: bing ads audience (#5299) * chore: handle 500kb limit, refactor to service impl (#5302) * chore: handle 500kb limit, refactor to service impl * chore: fix mock * chore: fix mock newline * chore: fix apiservice newline * chore: move error --------- Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com> * chore: release 1.38.2 (#5306) * fix: allow only enabled dest in backendSubscriber, fix klaviyo bulk (#5309) * chore: release 1.38.3 (#5311) * fix: disable vacuum at startup for reporting (#5325) * chore: remove full vacuum at flusher startup (#5332) * chore: release 1.38.4 (#5331) * update action to apidom-validate --------- Co-authored-by: Akash Chetty <achetty.iitr@gmail.com> Co-authored-by: Yashasvi Bajpai <33063622+yashasvibajpai@users.noreply.github.com> Co-authored-by: Sudip Paul <67197965+ItsSudip@users.noreply.github.com> Co-authored-by: siddarth.msv <82795818+Sidddddarth@users.noreply.github.com> Co-authored-by: mihir <mihir20121997@gmail.com> (cherry picked from commit 98827e5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Syncing patch release v1.38.4 to main branch
↓↓ Please review and edit commit overrides before merging ↓↓
BEGIN_COMMIT_OVERRIDE
fix: bq partitioning for additional columns (#5293)
fix: klaviyo bulk upload and BingAds OC (#5305)
fix: allow only enabled dest in backendSubscriber, fix klaviyo bulk (#5309)
fix: disable vacuum at startup for reporting (#5325)
chore: remove full vacuum at flusher startup (#5332)
END_COMMIT_OVERRIDE