Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: event_payload column can be JSONB or TEXT #5372

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Sidddddarth
Copy link
Member

@Sidddddarth Sidddddarth commented Dec 13, 2024

Description

event_payload column in newly created jobs tables will be TEXT columns.

Allows migrations from one type to the other, so changing from one to the other shouldn't fail. Changing back to JSONB would allow server processes to continue, however utility postgres functions like unionjobsdb would fail as the function definition returns table with different column types.

At startup(for w, rw jobsdbs) - we either update the last DS's event_payload column if empty or create a new dataset if the last has some jobs already - both provided the event type column of the last ds is different from what's configured.

Not a reloadable selection.

Allowed creating BYTEA columns but only for benchmark purposes. TEXT seems to be doing better and also avoids other character validation problems.

Linear Ticket

Resolves PIPE-1649

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@Sidddddarth Sidddddarth marked this pull request as draft December 13, 2024 10:33
@Sidddddarth Sidddddarth force-pushed the chore.jobsdbPayloadColumnType branch from c053da4 to c5c21e3 Compare December 13, 2024 12:02
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 66 lines in your changes missing coverage. Please review.

Project coverage is 74.73%. Comparing base (7425659) to head (37133be).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
jobsdb/jobsdb.go 60.86% 30 Missing and 6 partials ⚠️
jobsdb/migration.go 51.61% 26 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5372      +/-   ##
==========================================
- Coverage   74.77%   74.73%   -0.04%     
==========================================
  Files         437      437              
  Lines       61243    61392     +149     
==========================================
+ Hits        45793    45882      +89     
- Misses      12913    12968      +55     
- Partials     2537     2542       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sidddddarth Sidddddarth changed the title chore: event_payload column can be JSONB, BYTEA or TEXT chore: event_payload column can be JSONB or TEXT Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant