-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: event_payload column can be JSONB or TEXT #5372
Draft
Sidddddarth
wants to merge
11
commits into
master
Choose a base branch
from
chore.jobsdbPayloadColumnType
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+790
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sidddddarth
force-pushed
the
chore.jobsdbPayloadColumnType
branch
from
December 13, 2024 12:02
c053da4
to
c5c21e3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5372 +/- ##
==========================================
- Coverage 74.77% 74.73% -0.04%
==========================================
Files 437 437
Lines 61243 61392 +149
==========================================
+ Hits 45793 45882 +89
- Misses 12913 12968 +55
- Partials 2537 2542 +5 ☔ View full report in Codecov by Sentry. |
Sidddddarth
changed the title
chore: event_payload column can be JSONB, BYTEA or TEXT
chore: event_payload column can be JSONB or TEXT
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
event_payload
column in newly created jobs tables will beTEXT
columns.Allows migrations from one type to the other, so changing from one to the other shouldn't fail. Changing back to
JSONB
would allow server processes to continue, however utility postgres functions likeunionjobsdb
would fail as the function definition returns table with different column types.At startup(for
w
,rw
jobsdbs) - we either update the last DS's event_payload column if empty or create a new dataset if the last has some jobs already - both provided the event type column of the last ds is different from what's configured.Not a reloadable selection.
Allowed creating
BYTEA
columns but only for benchmark purposes.TEXT
seems to be doing better and also avoids other character validation problems.Linear Ticket
Resolves PIPE-1649
Security