-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: send sample event to reporting in async destinations #5396
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5396 +/- ##
==========================================
+ Coverage 74.70% 74.73% +0.03%
==========================================
Files 440 440
Lines 61432 61475 +43
==========================================
+ Hits 45894 45946 +52
+ Misses 12992 12988 -4
+ Partials 2546 2541 -5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with some minor comments.
Description
As of today, the destinations operating at batch router do not posess the capability of sending sample event to the reporting service. This is making it very difficult to debug in case of failures.
We are planning add
sampleEvent
data for batch router(async) destinations.Linear Ticket
Resolves INT-3077
Security