Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: send sample event to reporting in async destinations #5396

Merged
merged 6 commits into from
Jan 8, 2025

Conversation

sanpj2292
Copy link
Contributor

@sanpj2292 sanpj2292 commented Dec 24, 2024

Description

As of today, the destinations operating at batch router do not posess the capability of sending sample event to the reporting service. This is making it very difficult to debug in case of failures.

We are planning add sampleEvent data for batch router(async) destinations.

Linear Ticket

Resolves INT-3077

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@sanpj2292 sanpj2292 marked this pull request as ready for review January 6, 2025 12:06
@sanpj2292 sanpj2292 self-assigned this Jan 6, 2025
@sanpj2292 sanpj2292 changed the title chore: async destination reporting chore: send sample event to reporting in async destinations Jan 6, 2025
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 84.37500% with 15 lines in your changes missing coverage. Please review.

Project coverage is 74.73%. Comparing base (b51605a) to head (750b0de).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
router/batchrouter/handle_async.go 83.69% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5396      +/-   ##
==========================================
+ Coverage   74.70%   74.73%   +0.03%     
==========================================
  Files         440      440              
  Lines       61432    61475      +43     
==========================================
+ Hits        45894    45946      +52     
+ Misses      12992    12988       -4     
+ Partials     2546     2541       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

router/batchrouter/handle_async.go Outdated Show resolved Hide resolved
Copy link
Member

@achettyiitr achettyiitr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with some minor comments.

router/batchrouter/handle_async.go Outdated Show resolved Hide resolved
router/batchrouter/handle_async.go Outdated Show resolved Hide resolved
router/batchrouter/handle_async.go Outdated Show resolved Hide resolved
@sanpj2292 sanpj2292 enabled auto-merge (squash) January 8, 2025 05:45
@sanpj2292 sanpj2292 merged commit 688262e into master Jan 8, 2025
56 checks passed
@sanpj2292 sanpj2292 deleted the chore.async-dest-reporting branch January 8, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants