added AccountChooser in ssoPage url test #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! An important fix for sure. |
jontg
added a commit
to jontg/gsts
that referenced
this pull request
Aug 23, 2023
jontg
added a commit
to jontg/gsts
that referenced
this pull request
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the google session times out (or being signed out manually from the accounts settings), google give the "choose an account" page before signing in again:
This causes gsts to get stuck on "Logging in" phase, and it needs to be run with
--cleanargument in order to sign in again, which flaws the interactive way gsts works. I've fixed it by addingAccountChooserto the ssoPage url test, which then identifies this page, and spawns the browser for sign in again.( The url of the "choose an account" page is something like that:
https://accounts.google.com/AccountChooser/signinchooser?continue=https%3A%2F%2Faccounts.google.com%2Fo%2Fsaml2%2Finitsso%3Fidpid%XXXXXX%26spid%XXXXXX%26forceauthn%3Dtrue%26from_login%3DXXXXXX<mpl=popup&btmpl=authsub&scc=1&oauth=1&flowName=GlifWebSignIn&flowEntry=AccountChooser )