Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

Added Protein Data Bank citation reader #595

Merged
merged 4 commits into from
Oct 24, 2023
Merged

Conversation

joshuakto
Copy link
Contributor

@joshuakto joshuakto commented Oct 23, 2023

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Added feature to read primary citation of Protein Data Bank entries.

Type of Change

Please delete options that are not relevant.

  • New Loader/Tool

How Has This Been Tested?

  • Ran "poetry run pytest tests" to check that the added loader does not introduce new errors/warnings.
  • Added tests/test_pdb.py to test that the dataloader behaves as expected and return the right document object.

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have added a library.json file if a new loader/tool was added
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [N/A] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

Copy link
Collaborator

@EmanuelCampos EmanuelCampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did two comments, and the tests are broken, can you fix that? thanks for the PR

tests/test_pdb/test_pdb.py Show resolved Hide resolved
llama_hub/pdb/__init__.py Show resolved Hide resolved
@joshuakto
Copy link
Contributor Author

Thanks @EmanuelCampos! Updated the code base on the two comments, please feel free to suggest additional improvements.

@anoopshrma anoopshrma merged commit 9faa538 into run-llama:main Oct 24, 2023
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants