Add Dijkstra algorithm; fix a bunch of bugs; enable all edge weights #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: add debug tracing to all functions that modify the state arrays
Noting that it empties the queue
TODO: test that BellmanFord and Dijkstra give the same results given a graph with non-negative weights.
Because Bellman-Ford and Dijkstra find two different shortest paths with the same weight sum. Possible solution: deterministic sorting of output paths with equal length: `map (sortOn uniquePathId) (groupBy pathWeight resultPaths)`.
Also: improve assertion failure message
Synonym for "updateEdge"
Also: remove unused HasWeight constraints
How the hell was this not caught by any tests?! TODO: Write actually useful tests
``` cabal: Cannot test the package bellman-ford-0.1.0.0 because none of the components are available to build: the test suite 'bellman-ford-test' is not available because the solver did not find a plan that included the test suites. Force the solver to enable this for all packages by adding the line 'tests: True' to the 'cabal.project.local' file. ```
Not when a shorter distance is found TODO: Add TraceEvent_RelaxUpdate
runeksvendsen
force-pushed
the
dijkstra
branch
from
fb37821
to
9cac1e9
Compare
store "bottom" instead
|
Will reopen later when closer to done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6