Skip to content

Commit

Permalink
Cleanup CI steps (#4611)
Browse files Browse the repository at this point in the history
This is some changes I noticed we can make to CI:

- We remove the job "post performance numbers", which hasn't worked for
at least 6 months:
https://github.com/runtimeverification/k/actions/runs/8081624497
- Update some actions that were giving deprecated Node.js warnings.
  • Loading branch information
ehildenb authored Aug 28, 2024
1 parent 2fb4bf7 commit 09009d7
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 57 deletions.
56 changes: 0 additions & 56 deletions .github/workflows/develop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,59 +37,3 @@ jobs:
if git add --update && git commit --no-edit --allow-empty --message "Set Version: $(cat package/version)"; then
git push origin master
fi
post-performance-tests:
name: 'Performance Tests'
runs-on: [self-hosted, linux, normal]
continue-on-error: true
steps:
- uses: actions/checkout@v4
- name: 'Set up Docker Test Image'
env:
BASE_OS: ubuntu
BASE_DISTRO: jammy
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
BENCHER_API_TOKEN: ${{ secrets.BENCHER_API_TOKEN }}
BENCHER_PROJECT: k-framework
BENCHER_ADAPTER: json
run: |
set -euxo pipefail
workspace=$(pwd)
docker run --name "k-posting-profiling-tests-${GITHUB_SHA}" \
--rm -it --detach \
-e BENCHER_API_TOKEN="$BENCHER_API_TOKEN" \
-e BENCHER_PROJECT="$BENCHER_PROJECT" \
-e BENCHER_ADAPTER="$BENCHER_ADAPTER" \
-e GITHUB_HEAD_REF="$GITHUB_HEAD_REF" \
-e GITHUB_BASE_REF="$GITHUB_BASE_REF" \
-e GITHUB_TOKEN="$GITHUB_TOKEN" \
-e GITHUB_ACTIONS=true \
-e GITHUB_EVENT_NAME="$GITHUB_EVENT_NAME" \
-e GITHUB_EVENT_PATH="$GITHUB_EVENT_PATH" \
-e GITHUB_REPOSITORY="$GITHUB_REPOSITORY" \
-e GITHUB_REF="$GITHUB_REF" \
-e GITHUB_SHA="$GITHUB_SHA" \
--workdir /opt/workspace \
-v "${workspace}:/opt/workspace" \
-v "${GITHUB_EVENT_PATH}:${GITHUB_EVENT_PATH}" \
"${BASE_OS}:${BASE_DISTRO}"
- name: 'Setting up dependencies'
run: |
set -euxo pipefail
docker exec -t "k-posting-profiling-tests-${GITHUB_SHA}" /bin/bash -c './k-distribution/tests/profiling/setup_profiling.sh SKIP_K_BUILD'
- name: 'Getting Performance Tests Results'
run: |
set -euxo pipefail
docker exec -t "k-posting-profiling-tests-${GITHUB_SHA}" /bin/bash -c './k-distribution/tests/profiling/post_results_to_develop.py "${GITHUB_SHA}"'
- name: 'Posting Performance Tests Results'
run: |
set -euxo pipefail
docker exec -t "k-posting-profiling-tests-${GITHUB_SHA}" /bin/bash -c 'bencher run \
--if-branch "develop" --else-if-branch "master" \
--file .profiling-results.json --err --ci-only-on-alert \
--github-actions "${GITHUB_TOKEN}" "echo Exporting report"'
- name: 'Tear down Docker'
if: always()
run: |
docker stop --time=0 "k-posting-profiling-tests-${GITHUB_SHA}"
docker container rm --force "k-posting-profiling-tests-${GITHUB_SHA}" || true
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ jobs:
name: k-framework-binary

- name: 'Publish K to k-framework-binary cache'
uses: workflow/nix-shell-action@v3.3.0
uses: workflow/nix-shell-action@v3.3.2
env:
CACHIX_AUTH_TOKEN: '${{ secrets.CACHIX_PRIVATE_KFB_TOKEN }}'
GC_DONT_GC: '1'
Expand Down

0 comments on commit 09009d7

Please sign in to comment.