Mark InnerPicture as Send+Sync
#96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Picture` already was and it's just a ref-counting wrapper around it. Fixes rust-av#95
sdroege
commented
Mar 26, 2024
src/lib.rs
Outdated
| @@ -734,6 +732,9 @@ impl Picture { | |||
| unsafe impl Send for Picture {} | |||
| unsafe impl Sync for Picture {} | |||
There was a problem hiding this comment.
@lu-zero Do you want this to be removed and implicitly implemented? Same question for Plane.
There was a problem hiding this comment.
Sounds a good idea. Thank you :)
There was a problem hiding this comment.
So remove? Do you want to add something around static_assertions to ensure the traits are auto-implemented? :)
There was a problem hiding this comment.
As you prefer, the least code to confuse users the better though ^^
And add static assertions to ensure this actually happens.
sdroege
force-pushed
the
inner-picture-send
branch
from
611c527 to
ad1e575
Compare
|
@lu-zero Once merged, can you make a release? |
lu-zero
approved these changes
Mar 27, 2024
|
Can we have a release please? 🙏🏻 |
|
Sure, remind me tomorrow morning please :) |
|
Good morning Luca :) Can we have a release please? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picturealready was and it's just a ref-counting wrapper around it.Fixes #95