Add v2 serde #51
Merged
Add v2 serde #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add v2 message serde leveraging as much of rust-bitcoin's
NetworkMessageencodings as possible. There is some weirdness here since rust-bitcoin has aNetworkMessageas well as aRawNetworkMessagewrapper which focuses on the serde. TheRawNetworkMessageis V1 specific however (e.g. checksums and lengths) which does not play nice with V2. Some of the logic is spread across the structs.NetworkMessageis V2 friendly so that is our lingua franca here, but some bespoke code needed to be copied over for now.