test(protocol): add handshake with Bitcoin Core #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustaceanrob
force-pushed
the
test-08-09
branch
4 times, most recently
from
9518479 to
6ad7ade
Compare
nyonson
requested changes
Aug 9, 2024
| @@ -0,0 +1,3 @@ | |||
| bitcoind --chain=regtest --txindex --blockfilterindex --peerblockfilters --rpcport=18443 --rpcuser=test --rpcpassword=b324 --rest=1 --server=1 --listen=1 --v2transport=1 & | |||
| sleep 1 | |||
There was a problem hiding this comment.
Would be pretty easy to add a timeout to this in the future, maybe when we get it in to CI.
| #[test] | ||
| #[cfg(feature = "std")] | ||
| #[ignore = "CI"] | ||
| fn regtest_handshake() { |
There was a problem hiding this comment.
Wonder if we should put this in it's own file since it has a third party dependency?
There was a problem hiding this comment.
I would consider it an integration test even if it isn't ran in CI
rustaceanrob
force-pushed
the
test-08-09
branch
from
6ad7ade to
446fbfd
Compare
nyonson
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an integration test that can be run from a shell script. Would be a bit too lazy to add Bitcoin Core to CI so its ignored and mostly used to iterate on the API. Lmk what you think @nyonson
Update: Getting skill diffed by the CI.
rust-bitcoinbumped MSRV to 1.63.0 so I am going to see if that helps fix itUpdate 2: Yeah it fixed it. PR would also move MSRV to 1.63.0