No standard library (no_std) support #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustaceanrob
approved these changes
Mar 19, 2024
rustaceanrob
requested review from
rustaceanrob
and removed request for
rustaceanrob
rustaceanrob
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a crate feature flag which gates all implementation details which require the standard library. This feature flag is on by default, but follows the standard pattern where it can be disabled with the
default-featuresflag. BIP324's own deps have been cleaned up to only pull in std deps when necessary.Added a new CI check to make sure the library is actually
no_stdcompliant. Introduced thecrossdependency to do this since it was a little flaky locally, hopefully not too much trouble in CI.The Random Number Generator std dep required some minor interface tweaks where the RNG is passed down implicitly if called from a function that is only built for std.
All allocation dependencies are now explicit, but would need another rev to add another feature flag, e.g.
alloc, and gate that functionality as well. I think we would have to tweak some interfaces so kicked that can for the time being.