Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Italian DGC settings #39

Merged
merged 5 commits into from
Feb 14, 2022

Conversation

dodomorandi
Copy link
Contributor

@dodomorandi dodomorandi commented Jan 29, 2022

This is a prerequisite for #38.

Support for the school parameters is still missing -- there are only end fields, start is missing. Probably these fields must be related to some other start field, probably it will be more clear once we start implementing proper validation.

I am also not sure about IncompleteSettings: should it be non_exhaustive?

@dodomorandi dodomorandi self-assigned this Jan 29, 2022
src/settings.rs Outdated Show resolved Hide resolved
src/settings.rs Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2022

Codecov Report

Merging #39 (bcefef3) into main (aee00bd) will increase coverage by 0.39%.
The diff coverage is 85.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   84.73%   85.12%   +0.39%     
==========================================
  Files          11       12       +1     
  Lines         989     1862     +873     
==========================================
+ Hits          838     1585     +747     
- Misses        151      277     +126     
Impacted Files Coverage Δ
dgc-italy-core/src/settings.rs 85.56% <85.56%> (ø)
dgc-italy-core/src/lib.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aee00bd...bcefef3. Read the comment docs.

@dodomorandi dodomorandi force-pushed the dgc-settings branch 2 times, most recently from 70e4988 to 22e1f7c Compare February 7, 2022 20:51
Copy link
Collaborator

@lu-zero lu-zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Land it, we can iterate between validation and parsing from this PR.

@dodomorandi dodomorandi merged commit e9dbae9 into rust-italia:main Feb 14, 2022
@dodomorandi dodomorandi deleted the dgc-settings branch February 14, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants