Adapt SVGs to book theme #3277
Open
Adapt SVGs to book theme #3277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ericthelemur Any progress on this? |
|
I haven't looked at this for a while now, but I think it's still correct and complete. This solution has continued to worked well on my own mdbook. The only downside is having to inline svgs. I'll rebase it to current and check it is still valid |
ericthelemur
force-pushed
the
update-svgs
branch
from
35ed7a4
to
5115371
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue has been discussed in #74, and I've described my approach there. The idea is to
#includethe SVGs (avoiding Markdown formatting) and use existing CSS variables to match the theme.This will fall back to the original black and white if the CSS variables are unavailable.
Example in context:
