Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove only the unimportant printlns and not the error message which … #3727

Closed
wants to merge 1 commit into from
Closed

Remove only the unimportant printlns and not the error message which … #3727

wants to merge 1 commit into from

Conversation

zslot
Copy link

@zslot zslot commented Aug 20, 2023

…is enough important to be kept.

chriskrycho
chriskrycho reviewed Mar 29, 2024
View reviewed changes
Copy link
Contributor

@chriskrycho chriskrycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but I don't think we need to change this. The language here is clear that it is only removing the statements that were used to check the program's behavior, not any others. Thanks, though!

@zslot
Copy link
Author

zslot commented Apr 5, 2024

Thanks for checking and feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriskrycho chriskrycho chriskrycho left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zslot @chriskrycho