Convert Listings in Chapters 06-10 to <Listing>
#3973
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My bad, when I copy and pasted the captions from the `<span>` into the `<Listing>`, I failed to realize that my text editor copied over the line numbers into the strings. Removed them, should be all good now.
I am unsure whether this `<Listing>` will work properly due to no number being associated with it. @chriskrycho , since you implemented the pre-processor, could you please comment? (Sorry if there is a way that I could have checked this myself, I am unsure how to build the book. I'm just editing in plain-text and crossing my fingers, hope the whole thing doesn't come crumbling down when it's built.)
…READ DESC.)] I'm unsure whether wrapping the text may cause the listing text to be wrapped too as the newlines are found within quotation marks. If it causes issues, feel free to revert this commit. Another odd thing is that my editor uncolored the closing `</Listing>` tag when I split the lines. Maybe the newline characters need to be escaped with a backslash? Once again, this is untested code because I'm unsure how to test the book with the `<Listing>` preprocessor (and therefore don't know what my changes look like), as it hasn't been upstreamed yet and no instructions have been given on how to get the indev version to work.
SpectralPixel
changed the title
<Listing> (#3919)<Listing> ( #3919 )
SpectralPixel
changed the title
<Listing> ( #3919 )<Listing> #3919
SpectralPixel
changed the title
<Listing> #3919<Listing>
|
Thanks! I'll give it a look next week! If you’re up for it, would you mind splitting this into per-chapter PRs? That will make it way easier to land iteratively! |
|
I'll split them this week |
|
Excellent – thanks! |
Alright, I've opened the new PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed in favor of #3977, #3978, #3979, #3980 & #3981