infra: change how packages are opted out of workspaces #4083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `trpl`, `mdbook-trpl-note`, and `mdbook-trpl-listing` crates should *never* be part of a host workspace: neither in `rust-lang/book` nor in `rust-lang/rust`. They are always built as independent packages, so they do not end up depending implicitly on the host’s workspace dependencies. Accordingly, opt out by setting an empty `[workspace]` key in each of the packages' `Cargo.toml` files so that they do not have to be configured in both places they might be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
trpl,mdbook-trpl-note, andmdbook-trpl-listingcrates should never be part of a host workspace: neither inrust-lang/booknor inrust-lang/rust. They are always built as independent packages, so they do not end up depending implicitly on the host’s workspace dependencies.Accordingly, opt out by setting an empty
[workspace]key in each of the packages'Cargo.tomlfiles so that they do not have to be configured in both places they might be used.Helps unblock rust-lang/rust#131859