Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Rust 1.82 #4089

Merged
merged 6 commits into from
Nov 5, 2024
Merged

Update to Rust 1.82 #4089

merged 6 commits into from
Nov 5, 2024

Conversation

chriskrycho
Copy link
Contributor

Unblocks #4062

@chriskrycho chriskrycho marked this pull request as ready for review October 31, 2024 22:17
@chriskrycho chriskrycho marked this pull request as draft October 31, 2024 22:41
@chriskrycho chriskrycho marked this pull request as ready for review November 5, 2024 23:38
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted because inlined.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted because it was actually unused!

@@ -7,7 +7,7 @@ error[E0005]: refutable pattern in local binding
| ^^^^^^^ pattern `None` not covered
|
= note: `let` bindings require an "irrefutable pattern", like a `struct` or an `enum` with only one variant
= note: for more information, visit https://doc.rust-lang.org/book/ch19-02-refutability.html
= note: for more information, visit https://doc.rust-lang.org/book/ch18-02-refutability.html
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For posterity: I am going to let this be as it is, even though it’s “wrong” now, for two reasons.

  1. Although it doesn't match the book, it will get updated automatically when we bump to a version which includes Update TRPL to add new Chapter 17: Async and Await rust#131859, and then will stay in sync automatically after that.
  2. I put in redirects in Add HTML-based redirects for previous chapter numbering #4061 so anyone who does follow this will still end up on the correct page.

@chriskrycho chriskrycho merged commit f4b2254 into main Nov 5, 2024
6 checks passed
@chriskrycho chriskrycho deleted the rust-1.82 branch November 5, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant