Merge pull request #188 from Nilstrieb/remove-more-forbidden-knowledge

Prevent `@bors try-` from being used
rust-lang · Jan 5, 2023 · c8f51b8 · c8f51b8
2 parents 3abf0b0 + 567e557
commit c8f51b8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/homu/parse_issue_comment.py b/homu/parse_issue_comment.py
@@ -229,7 +229,9 @@ def parse_issue_comment(username, body, sha, botname, hooks=[]):
             commands.append(IssueCommentCommand.try_())
 
         elif word == 'try-':
-            commands.append(IssueCommentCommand.untry())
+            # Try- is broken, prevent its usage.
+            # commands.append(IssueCommentCommand.untry())
+            pass
 
         elif word in WORDS_TO_ROLLUP:
             rollup_value = WORDS_TO_ROLLUP[word]

diff --git a/homu/tests/test_parse_issue_comment.py b/homu/tests/test_parse_issue_comment.py
@@ -280,9 +280,7 @@ def test_try_minus():
     body = "@bors try-"
     commands = parse_issue_comment(author, body, commit, "bors")
 
-    assert len(commands) == 1
-    command = commands[0]
-    assert command.action == 'untry'
+    assert len(commands) == 0
 
 
 def test_rollup():