Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove squash from command list #187

Merged
merged 2 commits into from
Dec 14, 2022
Merged

Remove squash from command list #187

merged 2 commits into from
Dec 14, 2022

Conversation

Noratrieb
Copy link
Member

Squash is hopelessly broken and should never be used. (#136, #181).

Squash is hopelessly broken and should never be used.
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good, although maybe we should say "unsupported" or something like that instead?

@Mark-Simulacrum
Copy link
Member

Can we adjust the code to not run it as well, if that hasn't been done yet?

@Noratrieb
Copy link
Member Author

That sounds reasonable as well, I think disabling it like this should hopefully not break anything and safely disable it (hopefully).

@Noratrieb
Copy link
Member Author

@Mark-Simulacrum seems like you forgot about this

@Mark-Simulacrum Mark-Simulacrum merged commit 3abf0b0 into rust-lang:master Dec 14, 2022
@Noratrieb Noratrieb deleted the hide-forbidden-knowledge branch December 14, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants