Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update features.md to reflect minimum SIMD requirements #362

Closed
wants to merge 1 commit into from

Conversation

CKingX
Copy link

@CKingX CKingX commented May 4, 2024

  • Updated macOS minimum SIMD support from SSSE3 to SSE4.1 as macOS Sierra and later require Penryn
  • Included the minimum SIMD support for most Windows targets of SSE3

* Updated macOS minimum SIMD support from SSSE3 to SSE4.1 as macOS Sierra and later require Penryn
* Included the minimum SIMD support for most Windows targets of SSE3
@CKingX CKingX changed the title Update features.md Update features.md to reflect minimum SIMD requirements May 4, 2024
@CKingX
Copy link
Author

CKingX commented May 4, 2024

I don't think the tests are failing due to the change as I only updated the features page of the performance guide.

@workingjubilee
Copy link
Member

Oh yes, several fundamental ideas that this crate hinges on got rewritten.

@workingjubilee
Copy link
Member

@CKingX I have no intention of merging your change, sorry! This documentation should go to the rust-lang/rust repository, for the platform support pages hereish: https://github.com/rust-lang/rust/tree/master/src/doc/rustc/src

@CKingX CKingX closed this May 4, 2024
@CKingX
Copy link
Author

CKingX commented May 4, 2024

So I looked into the platform support and it doesn't make sense to put it in there. I also don't think constantly updating features.md whenever a target changes makes sense. Would it make sense to create a new PR explaining that you can look up the default target features with rustc --print cfg or for other targets, rustc --print cfg --target={target}?

@workingjubilee
Copy link
Member

Not even in the docs for the targets? https://github.com/rust-lang/rust/tree/master/src/doc/rustc/src/platform-support

And sure...?

@CKingX
Copy link
Author

CKingX commented May 4, 2024

Thanks! I will look into updating those docs.

@CKingX
Copy link
Author

CKingX commented May 4, 2024

It seems a lot of the docs on the targets list if things like SSE are disabled. Would it make sense updating the Windows 7 target arch to list it only supports SSE2 by default unlike the regular targets?

Also thank you for your help!

@CKingX CKingX deleted the patch-2 branch May 4, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants