Add a developer documentation to our book #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks very good to me overall; however, I would very much appreciate if you put a brief section dedicated to running this under custom toolchain, i.e which part of what scripts we should change in order to run this under custom toolchain, here's why I'm suggesting this: For creating less friction for the developer, as I tried to use this test suite as debugging tool to run test against, I couldn't figure out what settings to change, so I ended up hacking together version of |
I also made it a bit easier to override our scripts toolchain
|
@ouz-a Done |
|
LGTM! |
oli-obk
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a few notes on how to run tests. @ouz-a can you please review too?