Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not trigger missing_const_for_fn for tests #13945

Merged

Conversation

alex-semenyuk
Copy link
Member

Close #13938

changelog: [missing_const_for_fn]: do not trigger for tests

@rustbot
Copy link
Collaborator

rustbot commented Jan 5, 2025

r? @Manishearth

rustbot has assigned @Manishearth.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 5, 2025
}
}

// Allowing on this function, because it would lint, which we don't want in this case.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filled separate issue #13946

@alex-semenyuk alex-semenyuk force-pushed the ignore_test_missing_const_for_fn branch from d0a7688 to ca55534 Compare January 5, 2025 21:07
@Manishearth Manishearth added this pull request to the merge queue Jan 6, 2025
Merged via the queue into rust-lang:master with commit 0e2505b Jan 6, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clippy::missing_const_for_fn triggering for tests is kind of pointless
3 participants