Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set a custom auth header when requesting docs.rs origin servers #373

Merged
merged 2 commits into from
Dec 17, 2023

Conversation

syphar
Copy link
Member

@syphar syphar commented Dec 11, 2023

This is coming from this discussion on zulip

custom_header is not documented, but it exists: terraform-aws-modules/terraform-aws-cloudfront#69, linting seems to accept it too.

The value for the secret has to come from another source.

On other thing that is also missing: adding the secret value to the new docs.rs setup which is managed by simpleinfra here.

@syphar
Copy link
Member Author

syphar commented Dec 11, 2023

@Mark-Simulacrum here is the change itself, only the secret source would be missing.

Since the docs.rs server itself is still manually managed, adding the secret check to our config would be too

@Mark-Simulacrum Mark-Simulacrum marked this pull request as ready for review December 17, 2023 15:21
@Mark-Simulacrum Mark-Simulacrum merged commit 4e44aeb into rust-lang:master Dec 17, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants