Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Update crate version in Cargo.toml example #143

Merged
merged 3 commits into from
Nov 20, 2023
Merged

Conversation

MarijnS95
Copy link
Member

No description provided.

Copy link
Collaborator

@rib rib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these nice tidy ups!

Apart from needing to fixup the NonNull::new() change, this looks good to me.

@MarijnS95
Copy link
Member Author

MarijnS95 commented Nov 20, 2023

Apart from needing to fixup the NonNull::new() change, this looks good to me.

Must have misread that the Option it was assigned to a let binding rather than returned, while trying to scan for similar patterns that could use let-else. Changed it to a map now but perhaps it is better reverted (or turned into an if let Some(..) = NonNull::new { ...; Some(x) } else { None }).

@rib
Copy link
Collaborator

rib commented Nov 20, 2023

Changed it to a map now ...

yeah, seems reasonable to me

@rib rib merged commit 9fce890 into main Nov 20, 2023
6 checks passed
@rib rib deleted the readme-update-versions branch November 20, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants