Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce proc macros for scraper #203

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

LoZack19
Copy link
Contributor

As of now, the scraper proc macros are an independent crate, and they don't constitute an optional feature, which is what we want to achieve. Moreover the selector macro replicates parsing both at runtime and at complie time, because the objects from selectors crate don't implement quote's ToToken trait, which could allow us to adopt a more efficient approach. For all this reasons, I'll mark this as a draft for now.

@LoZack19 LoZack19 added the C-feature-request Category: feature request label Aug 30, 2024
@LoZack19 LoZack19 linked an issue Aug 30, 2024 that may be closed by this pull request
@cfvescovo
Copy link
Member

because the objects from selectors crate don't implement quote's ToToken trait, which could allow us to adopt a more efficient approach

I think we should wait for this to be implemented before providing an "official" proc macro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature-request Category: feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select::parse fails due to borrow the css query
2 participants