Split dpi module out into a separate crate
#3518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
madsmtm
force-pushed
the
dpi
branch
2 times, most recently
from
f01dfc4
to
fd08dcd
Compare
amrbashir
approved these changes
Feb 24, 2024
kchibisov
reviewed
Feb 24, 2024
| @@ -0,0 +1,39 @@ | |||
| [package] | |||
| name = "dpi" | |||
There was a problem hiding this comment.
what's the point to name it dpi and not winit-dpi, since it's tailored towards the dpi needs of winit?
There was a problem hiding this comment.
Mostly because the name dpi was free, but also because the crate isn't really fundamentally tied to Winit.
Friz64
reviewed
Feb 24, 2024
notgull
approved these changes
Feb 25, 2024
notgull
approved these changes
Feb 26, 2024
daxpedda
approved these changes
Feb 26, 2024
Co-authored-by: John Nunley <dev@notgull.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3433.
This PR is mostly about the documentation update, the actual API changes that Tauri needs can be done in subsequent PRs.
CHANGELOG.mdif knowledge of this change could be valuable to usersCC @amrbashir