Use Snap instead for Certbot + fix Shellcheck, and improve code quailty #3
reviewdog.yml
on: pull_request
Shellcheck testing
8s
Check spelling
11s
Annotations
2 errors and 6 warnings
Shellcheck testing:
install.sh#L135
[shellcheck (suggestion)] reported by reviewdog 🐶
Raw Output:
install.sh:135:- cd "$RUSTDESK_INSTALL_DIR"
install.sh:135:+ cd "$RUSTDESK_INSTALL_DIR" || exit
|
Check spelling:
install.sh#L287
[misspell] reported by reviewdog 🐶
"behaviour" is a misspelling of "behavior"
Raw Output:
./install.sh:287:12: "behaviour" is a misspelling of "behavior"
|
Shellcheck testing:
install.sh#L73
[shellcheck] reported by reviewdog 🐶
Not following: lib.sh: openBinaryFile: does not exist (No such file or directory) [SC1091](https://github.com/koalaman/shellcheck/wiki/SC1091)
Raw Output:
./install.sh:73:8:info:Not following: lib.sh: openBinaryFile: does not exist (No such file or directory) [SC1091](https://github.com/koalaman/shellcheck/wiki/SC1091)
|
Shellcheck testing:
install.sh#L78
[shellcheck] reported by reviewdog 🐶
ICyan is referenced but not assigned. [SC2154](https://github.com/koalaman/shellcheck/wiki/SC2154)
Raw Output:
./install.sh:78:26:warning:ICyan is referenced but not assigned. [SC2154](https://github.com/koalaman/shellcheck/wiki/SC2154)
|
Shellcheck testing:
install.sh#L91
[shellcheck] reported by reviewdog 🐶
IGreen is referenced but not assigned. [SC2154](https://github.com/koalaman/shellcheck/wiki/SC2154)
Raw Output:
./install.sh:91:22:warning:IGreen is referenced but not assigned. [SC2154](https://github.com/koalaman/shellcheck/wiki/SC2154)
|
Shellcheck testing:
install.sh#L108
[shellcheck] reported by reviewdog 🐶
IRed is referenced but not assigned. [SC2154](https://github.com/koalaman/shellcheck/wiki/SC2154)
Raw Output:
./install.sh:108:26:warning:IRed is referenced but not assigned. [SC2154](https://github.com/koalaman/shellcheck/wiki/SC2154)
|
Shellcheck testing:
install.sh#L135
[shellcheck] reported by reviewdog 🐶
Use 'cd ... || exit' or 'cd ... || return' in case cd fails. [SC2164](https://github.com/koalaman/shellcheck/wiki/SC2164)
Raw Output:
./install.sh:135:13:warning:Use 'cd ... || exit' or 'cd ... || return' in case cd fails. [SC2164](https://github.com/koalaman/shellcheck/wiki/SC2164)
|
Shellcheck testing:
install.sh#L167
[shellcheck] reported by reviewdog 🐶
Use "${var:?}" to ensure this never expands to / . [SC2115](https://github.com/koalaman/shellcheck/wiki/SC2115)
Raw Output:
./install.sh:167:16:warning:Use "${var:?}" to ensure this never expands to / . [SC2115](https://github.com/koalaman/shellcheck/wiki/SC2115)
|