-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
project CI refresh #50
Merged
Merged
Commits on Apr 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8710816 - Browse repository at this point
Copy the full SHA 8710816View commit details -
Configuration menu - View commit details
-
Copy full SHA for e205847 - Browse repository at this point
Copy the full SHA e205847View commit details -
* Reformats to better support parameters. * Adds merge_group trigger for supporting queued merges. * Adds cron scheduled build.
Configuration menu - View commit details
-
Copy full SHA for ec8137c - Browse repository at this point
Copy the full SHA ec8137cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b8d855 - Browse repository at this point
Copy the full SHA 9b8d855View commit details -
Configuration menu - View commit details
-
Copy full SHA for c37e519 - Browse repository at this point
Copy the full SHA c37e519View commit details -
Configuration menu - View commit details
-
Copy full SHA for aa5a444 - Browse repository at this point
Copy the full SHA aa5a444View commit details -
The `actions-rs/clippy-check` action is archived and there isn't a clear alternative. Since clippy is already being run in `rust.yml` the right fix seems to be removing this extra workflow.
Configuration menu - View commit details
-
Copy full SHA for 44b5451 - Browse repository at this point
Copy the full SHA 44b5451View commit details -
proj: fix unused_imports findings
Of the form: ``` warning: the item `AsRef` is imported redundantly --> src/tls.rs:5:21 | 5 | use core::convert::{AsRef, TryInto}; | ^^^^^ --> /rustc/a165f1f65015b1bd4afd2ec50700aaacf2e0c485/library/core/src/prelude/mod.rs:28:13 | = note: the item `AsRef` is already defined here | = note: `#[warn(unused_imports)]` on by default ```
Configuration menu - View commit details
-
Copy full SHA for 29c729e - Browse repository at this point
Copy the full SHA 29c729eView commit details -
build: add unused_qualification allow to codegen
Fixes warning of the form: ``` error: unnecessary qualification --> /home/daniel/Code/Rust/tls-parser/target/debug/build/tls-parser-f3ef275828190684/out/codegen.rs:2:53 | 2 | pub static CIPHERS: phf::Map<u16, TlsCipherSuite> = ::phf::Map { | ^^^^^^^^^^ | note: the lint level is defined here --> src/lib.rs:132:35 | 132 | /*unused_import_braces,*/ unused_qualifications)] | ^^^^^^^^^^^^^^^^^^^^^ help: remove the unnecessary path segments | 2 - pub static CIPHERS: phf::Map<u16, TlsCipherSuite> = ::phf::Map { 2 + pub static CIPHERS: phf::Map<u16, TlsCipherSuite> = phf::Map { | error: could not compile `tls-parser` (lib) due to 1 previous error ``` Unfortunately the `::phf` prefix is coming from a dependency, `phf_codegen`, and so isn't easily fixed: https://github.com/rust-phf/rust-phf/blob/999e6a260f03d82aa9d159465113294e7ed019e7/phf_codegen/src/lib.rs#L182
Configuration menu - View commit details
-
Copy full SHA for adbc84d - Browse repository at this point
Copy the full SHA adbc84dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9af2540 - Browse repository at this point
Copy the full SHA 9af2540View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a7d673 - Browse repository at this point
Copy the full SHA 4a7d673View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33427b3 - Browse repository at this point
Copy the full SHA 33427b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b0a76c - Browse repository at this point
Copy the full SHA 4b0a76cView commit details -
ci: add cargo test feature matrix
Adopts a similar feature matrix approach as the asn1-rs CI.
Configuration menu - View commit details
-
Copy full SHA for 8f9fdf2 - Browse repository at this point
Copy the full SHA 8f9fdf2View commit details -
Configuration menu - View commit details
-
Copy full SHA for f94a9b2 - Browse repository at this point
Copy the full SHA f94a9b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0fe3da1 - Browse repository at this point
Copy the full SHA 0fe3da1View commit details
Commits on Apr 16, 2024
-
proj: update MSRV to 1.63, commit lockfile
This matches the other Rusticata crates and fixes a build error with 1.60 from `memchr` requiring 1.61+ Note: we have two transitive dependencies that have bumped their MSRV within otherwise semver compatible versions: * `winnow` 0.4.2+ requires an MSRV of 1.64.0[0] * `toml_edit` 0.19.9+ requires an MSRV of 1.64.0[1] Recently the Rust project guidance on commiting lockfiles for library projects[2] was changed. They say: "A lockfile is an appropriate way to pin versions for your project so you can validate your MSRV" As a result I've opted to commit a lockfile and use `--locked` in CI to maintain MSRV. I think this is a better approach than manually working around the issue with `cargo update --precise` and in line with current best practices. [0]: https://github.com/winnow-rs/winnow/blob/v0.6.6/CHANGELOG.md#042---2023-04-28 [1]: https://github.com/toml-rs/toml/blob/main/crates/toml_edit/CHANGELOG.md#0199---2023-05-18 [2]: https://blog.rust-lang.org/2023/08/29/committing-lockfiles.html
Configuration menu - View commit details
-
Copy full SHA for 11eecc8 - Browse repository at this point
Copy the full SHA 11eecc8View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.