Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project CI refresh #50

Merged
merged 17 commits into from
Apr 20, 2024
Merged

project CI refresh #50

merged 17 commits into from
Apr 20, 2024

Commits on Apr 12, 2024

  1. proj: add .idea to .gitignore

    cpu committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    8710816 View commit details
    Browse the repository at this point in the history
  2. ci: workflow name before triggers

    cpu committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    e205847 View commit details
    Browse the repository at this point in the history
  3. ci: more 'on' triggers

    * Reformats to better support parameters.
    * Adds merge_group trigger for supporting queued merges.
    * Adds cron scheduled build.
    cpu committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    ec8137c View commit details
    Browse the repository at this point in the history
  4. ci: actions/checkout@v2/v1 -> v4

    cpu committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    9b8d855 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c37e519 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    aa5a444 View commit details
    Browse the repository at this point in the history
  7. ci: remove clippy-check

    The `actions-rs/clippy-check` action is archived and there isn't a clear
    alternative. Since clippy is already being run in `rust.yml` the right
    fix seems to be removing this extra workflow.
    cpu committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    44b5451 View commit details
    Browse the repository at this point in the history
  8. proj: fix unused_imports findings

    Of the form:
    ```
    warning: the item `AsRef` is imported redundantly
     --> src/tls.rs:5:21
      |
    5 | use core::convert::{AsRef, TryInto};
      |                     ^^^^^
     --> /rustc/a165f1f65015b1bd4afd2ec50700aaacf2e0c485/library/core/src/prelude/mod.rs:28:13
      |
      = note: the item `AsRef` is already defined here
      |
      = note: `#[warn(unused_imports)]` on by default
    ```
    cpu committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    29c729e View commit details
    Browse the repository at this point in the history
  9. build: add unused_qualification allow to codegen

    Fixes warning of the form:
    ```
    error: unnecessary qualification
       --> /home/daniel/Code/Rust/tls-parser/target/debug/build/tls-parser-f3ef275828190684/out/codegen.rs:2:53
        |
    2   | pub static CIPHERS: phf::Map<u16, TlsCipherSuite> = ::phf::Map {
        |                                                     ^^^^^^^^^^
        |
    note: the lint level is defined here
       --> src/lib.rs:132:35
        |
    132 |         /*unused_import_braces,*/ unused_qualifications)]
        |                                   ^^^^^^^^^^^^^^^^^^^^^
    help: remove the unnecessary path segments
        |
    2   - pub static CIPHERS: phf::Map<u16, TlsCipherSuite> = ::phf::Map {
    2   + pub static CIPHERS: phf::Map<u16, TlsCipherSuite> = phf::Map {
        |
    
    error: could not compile `tls-parser` (lib) due to 1 previous error
    ```
    
    Unfortunately the `::phf` prefix is coming from a dependency,
    `phf_codegen`, and so isn't easily fixed:
    
    https://github.com/rust-phf/rust-phf/blob/999e6a260f03d82aa9d159465113294e7ed019e7/phf_codegen/src/lib.rs#L182
    cpu committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    adbc84d View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    9af2540 View commit details
    Browse the repository at this point in the history
  11. ci: use nightly for clippy

    cpu committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    4a7d673 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    33427b3 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    4b0a76c View commit details
    Browse the repository at this point in the history
  14. ci: add cargo test feature matrix

    Adopts a similar feature matrix approach as the asn1-rs CI.
    cpu committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    8f9fdf2 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    f94a9b2 View commit details
    Browse the repository at this point in the history
  16. Cargo: remove stale travis refs

    cpu committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    0fe3da1 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. proj: update MSRV to 1.63, commit lockfile

    This matches the other Rusticata crates and fixes a build error with
    1.60 from `memchr` requiring 1.61+
    
    Note: we have two transitive dependencies that have bumped their MSRV
    within otherwise semver compatible versions:
    
    * `winnow` 0.4.2+ requires an MSRV of 1.64.0[0]
    * `toml_edit` 0.19.9+ requires an MSRV of 1.64.0[1]
    
    Recently the Rust project guidance on commiting lockfiles for library
    projects[2] was changed. They say:
    
    "A lockfile is an appropriate way to pin versions for your project so
    you can validate your MSRV"
    
    As a result I've opted to commit a lockfile and use `--locked` in CI to
    maintain MSRV. I think this is a better approach than manually working
    around the issue with `cargo update --precise` and in line with current
    best practices.
    
    [0]: https://github.com/winnow-rs/winnow/blob/v0.6.6/CHANGELOG.md#042---2023-04-28
    [1]: https://github.com/toml-rs/toml/blob/main/crates/toml_edit/CHANGELOG.md#0199---2023-05-18
    [2]: https://blog.rust-lang.org/2023/08/29/committing-lockfiles.html
    cpu committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    11eecc8 View commit details
    Browse the repository at this point in the history