examples: prefer pemfile::private_key #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This repo doesn't check in a lockfile, but it probably should? Fixing this sort of MSRV min version build error without is a bit annoying. @djc WDYT? |
|
+1. |
|
djc
approved these changes
Jul 9, 2024
Using `rustls_pemfile::rsa_private_keys` is overly specific, limiting use to just RSA keys with PKCS#1 encoding. This commit switches to using `rustls_pemfile::private_key` which is tailor made for loading one private key in any of the supported formats.
cpu
force-pushed
the
cpu-broader-pemfile-support
branch
from
6da3cdd
to
3640e58
Compare
|
@quininer Same thing here :-) Merging w/ one approval, but with the expectation that if you have feedback I will revisit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
rustls_pemfile::rsa_private_keysis overly specific, limiting use to just RSA keys with PKCS#1 encoding.This commit switches to using
rustls_pemfile::private_keywhich is tailor made for loading one private key in any of the supported formats.Updates #76