feat: adding pkgs support for cross-compilation #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpc
reviewed
Jul 1, 2024
dpc
reviewed
Jul 1, 2024
dpc
reviewed
Jul 1, 2024
| @@ -30,6 +30,7 @@ in | |||
| , clang-unwrapped ? defaultClangUnwrapped | |||
| , stdenv ? defaultStdenv | |||
| , isLintShell ? false | |||
| , craneArgs ? { } | |||
There was a problem hiding this comment.
Is this really needed? I thought we'd just modify mergeArgs to scan through buildInputs and buildNativeInputs and apply pkgs over functions there.
There was a problem hiding this comment.
I did try the mergeArgs route but it was a pain passing the buildInputs and nativeBuildInputs across different targets.
Resolving the packages as early as possible to pass it directly to mkFenixToolchain ended up working smoothly
|
We'll need tests in ./checks that make sure it works. But right now that |
|
Got it, thanks for the review. I did not manage to get |
|
Hey @dpc, coming back to this PR
Tell me if there are still blockers to merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #160.
This should not introduce any breaking changes, we can now pass a
buildInputsandnativeBuildInputslambda tocraneMultiBuildthat we get resolved inmkStdToolchainsand ultimately passed tocraneLibinmkFenixToolchain.EDIT: I just realized my new commits were also forwarded to this PR, they basically add new targets (linux musl variants + windows64 with mingw).