Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #326 (help-wanted) #365

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

sepiropht
Copy link
Contributor

#326
The add_item function is called two times with the same id.
In one iteration we call successively DataCountSection(section).parse_items(items, idx)?; and
items.add_root(ir::Item::new(id, name, size - added, ir::Misc::new())); with the same idx value.
That why we have a panic in the add_item function.
I'm suppose that id is the same because section's code is also the same ? I didn't understand further

@fitzgen
Copy link
Member

fitzgen commented Oct 25, 2019

Hey @sepiropht, can you create a test case and steps to reproduce the bug? That would help diagnose the problem and come up with what the correct fix might be. Thanks!

@sepiropht
Copy link
Contributor Author

To reproduce the bug i just used the file that was referenced in the issue raytrace_parallel_bg.wasm.gz
twiggy top raytrace_parallel_bg.wasm

@data-pup
Copy link
Member

Hey @sepiropht! @fitzgen added a small test case you can use, over in #326. You should be able to use that to help finish this up. Thanks so much for opening a PR, and sorry about the slow reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants