Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release workflow #3680

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update release workflow #3680

wants to merge 1 commit into from

Conversation

ranile
Copy link
Collaborator

@ranile ranile commented Nov 2, 2023

Combine bump and release into a single step

Combine bump and release into a single step
@ranile ranile requested a review from daxpedda November 2, 2023 16:14
- run: rustc publish.rs
- name: assert we're on bump branch
run: test "$(git git branch --show-current)" = "bump"
- run: git commit -S -F /tmp/msg
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will GitHub handle -S for signed commits properly? Not sure

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No clue, worth the try.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See actions/runner#667

As far as I understand you can't with the default git config, but there are some workarounds.

Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants