Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support no-capture behavior in wasm-bindgen-test #3800

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Ekleog
Copy link
Contributor

@Ekleog Ekleog commented Jan 20, 2024

Note: this is still a draft, I need to put that behind a config option. But before I complete it all, I wanted to get an idea what y'all think about this?

My context is, I want to fuzz a crate of mine that needs to run in a browser. I cannot fuzz for now, because fuzzers don't support wasm32. So I want to at least have a very long-running proptest that generates random data.

But then in order to be able to know what's happening, I now need to have a view of what the test actually displays, so that I can distinguish between "running fine" and "deadlocked/panicked".

So before I turn it into a proper configuration option, WDYT about this change?

@daxpedda
Copy link
Collaborator

daxpedda commented Jan 21, 2024

I'm not entirely sure what exactly you are trying to show in the shell, but in general it would be good if we align more with cargo test:

  • We should show test results in the shell as soon as possible, no reason to wait until everything is done.
  • Using --nocapture should I guess show the console output in the shell if there is any.

Currently the output in the shell is a complete mess, so any improvements on that front are appreciated.

@daxpedda daxpedda added the waiting for author Waiting for author to respond label Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for author Waiting for author to respond
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants