New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to catch2 includes and macOS build #71

Open

barracuda156 wants to merge 3 commits into rvarago:master from barracuda156:catch2

barracuda156 commented Jan 4, 2023

This PR fixes the following:

Wrong catch2 headers: the current version of catch2 does not have catch2/catch.hpp (so the build errs out), it should be catch2/catch_all.hpp.
Missing compiler flag for C++17: there are numerous build errors when those are not passed.
Linking on macOS: it currently fails with missing _main symbol (at least for some macOS versions). Fixed.

barracuda156 added 3 commits

January 4, 2023 23:46


Fix catch2 includes

b489e5c


tests/CMakeLists.txt: require C++17

e4f1ca4


Fix missing _main on macOS

b69974d

barracuda156 force-pushed the catch2 branch from c93f033 to b69974d Compare

January 4, 2023 16:47

barracuda156 mentioned this pull request

Fixes to catch2 includes and building on macOS rvarago/kitten#33

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment