Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix to python API and gitignore #5

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

saurabh1002
Copy link
Contributor

@saurabh1002 saurabh1002 commented Sep 10, 2024

Thanks for you amazing contribution @simone-ferrari and team. Firstly, the package builds without issues, which is amazing. I am currently running your pipeline to see how it performs, and I ran into some small issues which I propose to fix in this PR.

  1. The line */build/* in .gitignore does not actually ignore the build directory.
  2. The poses saved in KITTI format had a trailing whitespace at end of each line which was throwing an error (see image below) when passed to the commonly used evo pipeline for computing odometry evaluation metrics.

image

I propose a fix two the above issues through the commits in this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is to open the file in append mode.
The truncate call basically clears existing contents of the file if it existed before, which the write mode does by default, but not the append mode.

Copy link
Contributor

@simone-ferrari simone-ferrari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @saurabh1002 !

@simone-ferrari simone-ferrari merged commit 9802145 into rvp-group:main Sep 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants