Adds support for ABQ_WORKER, ABQ_RUNNERS, and ABQ_BATCH_SIZE environment variables #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TAGraves
force-pushed
the
tg-abq-envvars
branch
from
a436e22 to
ab65591
Compare
crates/abq_cli/src/args.rs
Outdated
| short = 'n', | ||
| required = false, | ||
| default_value = "1", | ||
| env("ABQ_RUNNERS_NUM") |
There was a problem hiding this comment.
Can this just be ABQ_RUNNERS? 🤔
There was a problem hiding this comment.
I made this change. I got spooked because the CLI flag is --num but I don't think it's a big deal
There was a problem hiding this comment.
Oh interesting 🤔 I don't care for that either but it's probably too late at this point 😂
There was a problem hiding this comment.
and ABQ_NUM also seems not right 🤷♂️
eh whatever you think is best
…ronment variables
TAGraves
force-pushed
the
tg-abq-envvars
branch
from
ab65591 to
f31e0f8
Compare
TAGraves
changed the title
kylekthompson
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some environments (e.g. using ABQ with Captain in CI) it can be handy to just set environment variables for these values instead of passing flags in.