Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with Rails 6. #34

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

expeehaa
Copy link

This branch fixes #33.
It also drops support for Rails 3 and 4 because I had difficulties running appraisal install with these old Rails versions and figured that they shouldn’t be supported anymore anyway.

@expeehaa expeehaa force-pushed the add_compatibility_with_rails_6 branch from 760eb6a to d63b907 Compare May 28, 2021 00:03
@olliebennett
Copy link

This branch has been working well for me for months; would love to see it merged in if possible! 👍 Thanks

In the meantime, myGemfile contains;

# Nested layouts
# Using GitHub PR branch until https://github.com/rwz/nestive/pull/34 is merged
gem 'nestive', github: 'expeehaa/nestive', branch: 'add_compatibility_with_rails_6'

@rwz
Copy link
Owner

rwz commented Apr 12, 2022

Any reason this drops 3.1 support? It seems to be that it should be pretty straightforward to retain it.

Edit: Oh nevermind, actually read your PR comment, lol. 🤦‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Absoulte Path deprecation warning in Rails 6
3 participants