Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bounceout/bouncein tweens. #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Silver-Hawk
Copy link

Added standard flux style function for bounce tween.

@rxi
Copy link
Owner

rxi commented Oct 31, 2015

Apologies for the slow response.

Although I appreciate the effort it looks like you put in -- especially with keeping with the style of the existing tween types -- I fear this addition might begin pushing the library in a direction away from "lightweight" which it maintains as one of its goals.

I'll leave the pull request open for the time being so it does not get lost. I may rework some parts of the library in the future in which case additional tween-types might find a place.

Thanks

@Jasoco
Copy link

Jasoco commented Sep 26, 2016

Actually I like having the bounce option. I added the code for it from this modification to the flux.lua I have in my project and it works great. Bounce is really useful and I'd be happy if you decided to make it part of the official library. Just my two cents. I'm glad I Googled for an answer before trying to implement it myself.

@Silver-Hawk
Copy link
Author

@Jasoco Glad you liked it :) I also use it a lot so I thought it might be useful :)
@rxi No worries, I understand why you think it's not as clean as the usual functions, but I searched the web for a cleaner version before I made it, but without luck, it can however possible be simplified :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants