Skip to content

Commit

Permalink
FontAwesome: Scale glyphs a bit smaller
Browse files Browse the repository at this point in the history
[why]
With Nerd Fonts v3.2.0 Font Awesome was updated to 6.5.1.

A lot icons got replaced and so the scaling was completely different
then with the old Font Awesome version as the icons were different.

Some complained that the new icons were to small, so that was fixed with
Nerd Fonts v3.2.1, where the size was increased by "approx 10%".

Now this seems a bit on the big side, so we decrease the size a bit.

[how]
v3.2.0   EM 1400    relative size 1.00
v3.2.1   EM 1200    relative size 1.17
v3.3.0   EM 1300    relative size 1.08

So we go to 92% of v3.2.1, i.e. -8% in height.

Note that the original change with v3.2.1 was +17% instead of the
intended 10% :-(

That 10% was just "some random number out of the blue".

Related: #1588
Fixes: #1614

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
  • Loading branch information
Finii committed Oct 28, 2024
1 parent 93300dc commit c7b28f0
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion bin/scripts/lib/i_fa.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Font Awesome (version 6.5.1, 1475 icons, 342 aliases)
# Does not include all icons of the release
# Codepoints: ED00-F2FF with gaps
# Nerd Fonts Version: 3.2.1
# Nerd Fonts Version: 3.2.0
# Script Version: (autogenerated)
test -n "$__i_fa_loaded" && return || __i_fa_loaded=1
i='' i_fa_location_dot=$i
Expand Down
Binary file modified src/glyphs/font-awesome/FontAwesome.otf
Binary file not shown.
4 changes: 2 additions & 2 deletions src/glyphs/font-awesome/generate
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,8 @@ for _, codepoint, file, *names in mapping:
num_icons = len(mapping)

print('Generating {} with {} glyphs'.format(fontfile, num_icons))
font.ascent = 1000
font.descent = 200
font.ascent = 1050
font.descent = 250
font.generate(os.path.join(fontdir, fontfile), flags=("no-FFTM-table",))

codepoints = [ int(p, 16) for _, p, *_ in mapping ]
Expand Down

0 comments on commit c7b28f0

Please sign in to comment.