Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Font Logos to 1.3.0 #1721

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Update Font Logos to 1.3.0 #1721

merged 1 commit into from
Oct 28, 2024

Conversation

Finii
Copy link
Collaborator

@Finii Finii commented Oct 28, 2024

Description

Update Font Logos to 1.3.0:

image

Requirements / Checklist

  • Read the Contributing Guidelines
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan.
    Issue number where discussion took place: #xxx
  • If this contains a font/glyph add its origin as background info below (e.g. URL)
  • Verified the license of any newly added font, glyph, or glyph set. License is: xxx

What does this Pull Request (PR) do?

Add the new icons of Font Logos, existing icons of Font Logos were not touched upstream.

How should this be manually tested?

Any background context you can provide?

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii
Copy link
Collaborator Author

Finii commented Oct 28, 2024

Shellcheck failed due to unrelated file, needs separate PR

./bin/scripts/archive-fonts.sh:60:10: note: Double quote to prevent globbing and word splitting. [SC2086]

@Finii
Copy link
Collaborator Author

Finii commented Oct 28, 2024

Result looks good, Font Logos marked blue:

image

@Finii Finii merged commit 2123aea into master Oct 28, 2024
4 of 5 checks passed
@Finii Finii deleted the feature/font-logos-1.3.0 branch October 28, 2024 15:28
@Finii
Copy link
Collaborator Author

Finii commented Oct 28, 2024

Noooo, River is missing?!! 😒

Edit: Fixed via 4ab9d89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant