Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add Obsidian folder option #14

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

mbbroberg
Copy link

Closes #13

Copy link
Owner

@saberzero1 saberzero1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr, I'll test it later today.

src/repositoryConnection/RepositoryConnection.ts Outdated Show resolved Hide resolved
src/repositoryConnection/RepositoryConnection.ts Outdated Show resolved Hide resolved
src/repositoryConnection/RepositoryConnection.ts Outdated Show resolved Hide resolved
@mbbroberg
Copy link
Author

@saberzero1 I'm working to remove that commit, but so you understand why: I removed that path because I correlated it to the additional content at the beginning of commits like this one. Once removed, I was able to map successfully to my file structure. Is there anything you noticed about what you see in my commit history to help resolve this issue as well?

@saberzero1
Copy link
Owner

I think the problem is the method of link resolution.

I use absolute path and it seems to work fine. You seem to use shortest path, which apparently doesn't work.

I'll test your code to confirm if it works for both shortest path and absolute path.

Ultimately I should probably let users configure their preferred option. Or perhaps get their preferred option from their quartz.config.ts file.

@mbbroberg
Copy link
Author

@saberzero1 that's definitely it -- I do use shortest path. I backed out of the change but there's a bug in that behavior as noted. I'll consider that out of scope for this feature. Thanks!

@saberzero1 saberzero1 self-requested a review May 23, 2024 12:24
main.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set Obsidian folder path to map to content folder
2 participants