Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: transclude improvements #16

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

HyperEpsilon
Copy link

This PR does three things.

  1. Move the transcluded image regexs into the regexes file and import it, reducing duplicate code
  2. add bmps to the list of transcluded images
  3. improve the transcluded images regex to account for images in tables that have an escaped pipe

Things to note: svgs are handled in a separate step than other images and I haven't looked at them yet. There's a good chance that svgs embeded in tables with custom data after the pipe don't work, but I haven't investigated that yet

@HyperEpsilon HyperEpsilon changed the title Transclude improvements feat: transclude improvements Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant