Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle 404 in CardDAV multi get - refs #829 #1503

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DeepDiver1975
Copy link
Member

rebased #904

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #1503 (e61f0a0) into master (9fb8b91) will decrease coverage by 0.01%.
The diff coverage is 96.77%.

@@             Coverage Diff              @@
##             master    #1503      +/-   ##
============================================
- Coverage     97.32%   97.32%   -0.01%     
- Complexity     2833     2841       +8     
============================================
  Files           175      175              
  Lines          9425     9443      +18     
============================================
+ Hits           9173     9190      +17     
- Misses          252      253       +1     
Files Coverage Δ
lib/CardDAV/AddressBook.php 92.00% <100.00%> (+0.10%) ⬆️
lib/DAV/Client.php 92.62% <ø> (ø)
lib/DAV/Server.php 96.91% <100.00%> (+0.03%) ⬆️
lib/DAV/Xml/Element/Response.php 93.58% <100.00%> (ø)
lib/DAV/Tree.php 99.25% <92.30%> (-0.75%) ⬇️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@DeepDiver1975
Copy link
Member Author

rebased - @clxmstaab @phil-davis mind a review? THX

Copy link
Member

@staabm staabm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -124,7 +124,7 @@ public function xmlSerialize(Writer $writer): void
$writer->writeElement('{DAV:}href', $writer->contextUri.\Sabre\HTTP\encodePath($this->getHref()));

$empty = true;
$httpStatus = $this->getHTTPStatus();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we should raise the phpstan level to catch such things :)
(separate PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants